Updating on and off#54
Merged
Antonio-Laguna merged 3 commits intofirstandthird:masterfrom Jul 15, 2022
Merged
Conversation
dawnerd
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update slightly reverts changes by previous PR on #53
offis basically broken and I wouldn't use it but wouldn't touch it either, see #37 .Regarding
on, this offloads the decision of making eventspassiveto something else, may be the user or may that beDomodulebut there are cases in which you'd want atouchstartto be cancelable (if you understand the perf hit) and the previous PR stole that ability from you.